Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added warning message for deprecated flag #193

Merged
merged 2 commits into from
Aug 10, 2022
Merged

added warning message for deprecated flag #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c11e52f
added warning message for deprecated flag
laxmikantbpandhare Aug 10, 2022
28e1340
updated markdeprecated
laxmikantbpandhare Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/plugins/helm/v1/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ func (p *createAPISubcommand) BindFlags(fs *pflag.FlagSet) {
fs.StringVar(&p.options.chartOptions.Version, helmChartVersionFlag, "", "helm chart version (default: latest)")

fs.StringVar(&p.options.CRDVersion, crdVersionFlag, defaultCrdVersion, "crd version to generate")
_ = fs.MarkDeprecated(crdVersionFlag, util.WarnMessageRemovalV1beta1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that to work with v1beta1 we need old versions of controller-gen and controller-runtime deps so I do not think that this option can work well. Therefore, I think that we could also remove them since the plugin is alpha.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varshaprasad96 wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed @camilamacedo86. But does the helm plugin in SDK has removed it? We need to be consistent with the changes happening in SDK's Helm and the one here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like its not (https://github.com/operator-framework/operator-sdk/blob/fd893783327b68fbbdd118cbc0b4e1b6d4370b4c/internal/plugins/helm/v1/api.go#L128). Can we remove it there first?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varshaprasad96 the helm one is v1 so we could not remove but that is probably not working there without the user downgrading the controller tools used manually.

Here is a little worst because that would mean changing the go.mod either to downgrade the controller runtime as well.

However, anyway, if we want here to deprecate for now and remove afterwords I am ok with too 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @camilamacedo86 and @varshaprasad96. This PR got two approvals so I am merging it now.

}

func (p *createAPISubcommand) InjectConfig(c config.Config) error {
Expand Down
20 changes: 20 additions & 0 deletions pkg/plugins/util/message.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// Copyright 2020 The Operator-SDK Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package util

const WarnMessageRemovalV1beta1 = "The v1beta1 API version for CRDs and Webhooks is deprecated and is no longer offered since " +
"Kubernetes 1.22. This flag will be removed in a future release. We " +
"recommend that you no longer use the v1beta1 API version" +
"More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-22"