Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the non-deprecated SimpleIntervalClock fake kubeclock #199

Merged

Conversation

misberner
Copy link
Contributor

The code as well as the test only require a PassiveClock, i.e., a clock that only supports querying the current time, without the ability to schedule future tasks in the style of time.After. That allows the use of a SimpleIntervalClock, which is not deprecated.

Note: IntervalClock doesn't do anything more than SimpleIntervalClock, as all the methods not implemented by SimpleIntervalClock would just panic anyway.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3173107206

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.223%

Totals Coverage Status
Change from base Build 3067817681: 0.0%
Covered Lines: 1631
Relevant Lines: 1828

💛 - Coveralls

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @misberner ! The change looks good to me.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2022
@joelanford joelanford merged commit 1375ea2 into operator-framework:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sdk area/testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants