-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing duplicate fix target #201
Conversation
Signed-off-by: jesus m. rodriguez <jmrodri@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @jmrodri !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
lint: | ||
fetch golangci-lint 1.45.2 && golangci-lint run | ||
lint: setup-lint | ||
golangci-lint run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we missing to exit if tree is unclean? git diff --exit-code
. Either in lint
or fix
Pull Request Test Coverage Report for Build 3252557916
💛 - Coveralls |
Signed-off-by: jesus m. rodriguez jmrodri@gmail.com