Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing duplicate fix target #201

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Conversation

jmrodri
Copy link
Member

@jmrodri jmrodri commented Oct 14, 2022

Signed-off-by: jesus m. rodriguez jmrodri@gmail.com

Signed-off-by: jesus m. rodriguez <jmrodri@gmail.com>
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @jmrodri !

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

lint:
fetch golangci-lint 1.45.2 && golangci-lint run
lint: setup-lint
golangci-lint run
Copy link
Member

@varshaprasad96 varshaprasad96 Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we missing to exit if tree is unclean? git diff --exit-code. Either in lint or fix

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3252557916

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.223%

Totals Coverage Status
Change from base Build 3067817681: 0.0%
Covered Lines: 1631
Relevant Lines: 1828

💛 - Coveralls

@jmrodri jmrodri merged commit 8d2cd17 into operator-framework:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants