Use hybrid controller instead of the pre-built version #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
varshaprasad96
requested changes
Apr 10, 2023
pkg/plugins/hybrid/v1alpha/scaffolds/internal/templates/makefile.go
Outdated
Show resolved
Hide resolved
skattoju
force-pushed
the
makefile_hybrid_controller
branch
3 times, most recently
from
97c8f44
to
8dbd443
Compare
openshift-merge-robot
removed
the
needs-rebase
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
skattoju
force-pushed
the
makefile_hybrid_controller
branch
from
8dbd443
to
4f949ba
Compare
varshaprasad96
requested changes
Apr 12, 2023
skattoju
force-pushed
the
makefile_hybrid_controller
branch
2 times, most recently
from
cf0593f
to
2aedeff
Compare
skattoju
force-pushed
the
makefile_hybrid_controller
branch
from
2aedeff
to
5bedeb4
Compare
|
@camilamacedo86 @SimonBaeumer ptal 👀 |
|
I think requested changes have been made but varsha is off so could you please take a look @camilamacedo86 @SimonBaeumer 👀 |
everettraven
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
@skattoju Thanks for taking this on! These changes look good to me!
/lgtm
|
@skattoju It does look like @varshaprasad96 's concerns have been addressed. I'd be happy to merge this pending another approving review to make sure I didn't miss anything. @oceanc80 or @theishshah would either of you mind taking a look? |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to update the makefile template so that when a hybrid helm operator is skaffolded the hybrid controller is used instead of the pre-built one supplied with operator sdk