Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(dx): remove explicit CGO_ENABLED=0 to not block FIPS compliant builds/confusion #222

Merged
merged 1 commit into from
Jul 20, 2023
Merged

(dx): remove explicit CGO_ENABLED=0 to not block FIPS compliant builds/confusion #222

merged 1 commit into from
Jul 20, 2023

Conversation

everettraven
Copy link
Contributor

Description:

  • Removes all CGO_ENABLED=0 references

Motivation:

  • We shouldn't block builds from being able to be FIPS compliant by hardcoding the CGO_ENABLED=0 setting throughout our code

@everettraven
remove explicit CGO_ENABLED=0
61d434e 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
rashmigottipati
rashmigottipati approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2023
@oceanc80
Copy link
Contributor

/lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5613376493

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.498%
Totals Coverage Status
Change from base Build 4940267938: 0.0%
Covered Lines: 1713
Relevant Lines: 1914
💛 - Coveralls

@rashmigottipati rashmigottipati merged commit dcf106e into operator-framework:main Jul 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashmigottipati rashmigottipati rashmigottipati approved these changes

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@porridge porridge Awaiting requested review from porridge

Assignees

@rashmigottipati rashmigottipati

@oceanc80 oceanc80

Labels
area/infra area/sdk area/testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@everettraven @oceanc80 @coveralls @rashmigottipati