Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go to v1.21 #242

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Bump go to v1.21 #242

merged 3 commits into from
Oct 12, 2023

Conversation

rashmigottipati
Copy link
Member

@rashmigottipati rashmigottipati commented Oct 12, 2023 •
edited
Loading

Upgrade go version to 1.21

@rashmigottipati
Update go version to 1.21
17ffeaf 
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
everettraven
everettraven approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a nit about making the actions use the go.mod file for determining go version to use, but shouldn't block this PR

@everettraven
Copy link
Contributor

Looks like the testdata needs to be regenerated

@rashmigottipati
Run make generate
4415ddd 
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@rashmigottipati
Update GitHub actions to pull Go version from go.mod file
98ac3ef 
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@rashmigottipati rashmigottipati mentioned this pull request Oct 12, 2023
Closed
everettraven
everettraven approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@rashmigottipati rashmigottipati merged commit d02e119 into operator-framework:main Oct 12, 2023
6 checks passed
@rashmigottipati rashmigottipati deleted the update-go-version branch October 12, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven everettraven approved these changes

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

Assignees

@everettraven everettraven

Labels
area/deps area/infra area/sdk area/testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rashmigottipati @everettraven