Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ rapid reset scaffold remediation #288

Merged
merged 4 commits into from
Jan 18, 2024
Merged

✨ rapid reset scaffold remediation #288

merged 4 commits into from
Jan 18, 2024

Conversation

everettraven
Copy link
Contributor

Description

  • Update the hybrid plugin Go scaffolding to add a flag to enable/disable http/2 and enable/disable secure metrics serving.
  • Update the helm-operator and hybrid-operator run commands to have the same flags as ^
  • Update the hybrid scaffolding as necessary until regenerating the testdata and running make build results in a successful build

Motivation

  • Reduce the manual effort required for new operators to disable HTTP/2 to address:
  • Remediate the helm-operator and hybrid-operator run commands for the above CVEs by providing options to enable/disable HTTP/2

@everettraven
add flags to disable HTTP/2 and securely serve metrics
4e904fe 
in both the hybrid scaffolds and the binaries produced by this
project for running helm and hybrid-helm operators to finish remediation
of:
GHSA-qppj-fm5r-hxr3
GHSA-4374-p667-p6c8

Signed-off-by: everettraven <everettraven@gmail.com>
@everettraven
add missing import to hybrid scaffolding and regenerate testdata
3cc267f 
Signed-off-by: everettraven <everettraven@gmail.com>
@everettraven
remove Port field from scaffolded manager.Options
84c30cc 
Signed-off-by: everettraven <everettraven@gmail.com>
@everettraven
update hybrid scaffolding to point to the appropriate main.go in Make…
c7f9759 
…file and Dockerfile

Signed-off-by: everettraven <everettraven@gmail.com>
@everettraven everettraven changed the title ❇️ rapid reset scaffold remediation ✨ rapid reset scaffold remediation Jan 18, 2024
@grokspawn grokspawn added this pull request to the merge queue Jan 18, 2024
Merged via the queue into operator-framework:main with commit 4e326df Jan 18, 2024
6 checks passed
@everettraven everettraven deleted the cve/rapid-reset-scaffold-remediation branch January 18, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grokspawn grokspawn grokspawn approved these changes

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@SimonBaeumer SimonBaeumer Awaiting requested review from SimonBaeumer

Assignees
No one assigned
Labels
area/main-binary area/sdk area/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@everettraven @grokspawn