-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actionConfigGetter: allow custom mapping from object to rest.Config #317
actionConfigGetter: allow custom mapping from object to rest.Config #317
Conversation
224a2f4
to
ad4004c
Compare
ad4004c
to
a80ec8e
Compare
dab33f0
to
5a43aa9
Compare
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
5a43aa9
to
5a44fe1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 85.06% 85.69% +0.62%
==========================================
Files 19 19
Lines 1346 1510 +164
==========================================
+ Hits 1145 1294 +149
- Misses 125 139 +14
- Partials 76 77 +1 ☔ View full report in Codecov by Sentry. |
FTR, I cherry-picked this change to what stackrox operator uses and ran our e2e tests in a loop to see if this would provoke increased memory usage like it did before #198 but found no adverse effects. With this change: Without this change: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just one question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
6e98159
Fixes #316