Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hybrid plugin scaffolding #99

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Update hybrid plugin scaffolding #99

merged 2 commits into from
Aug 5, 2021

Conversation

varshaprasad96
Copy link
Member

This commit:

  1. Adds additional customizations to be done in config/ as
    post-scaffolding step in init command.
  2. Modify Dockerfile template.
  3. Modify main.go to accept additional flags for watches.yaml and
    leader-election-id.

Signed-off-by: varshaprasad96 varshaprasad96@gmail.com

TODO:

  • Update the commit hash of helm-operator-plugin in main.go after the pr is merged.
  • Update testdata/

@varshaprasad96
Update hybrid plugin scaffolding
e959fe4 
This commit:
1. Adds additional customizations to be done in config/ as
   post-scaffolding step in init command.
2. Modify Dockerfile template.
3. Modify main.go to accept additional flags for watches.yaml and
   leader-election-id.

Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
@coveralls
Copy link

coveralls commented Jul 26, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1091899423

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.734%
Totals Coverage Status
Change from base Build 999232256: 0.0%
Covered Lines: 1381
Relevant Lines: 1539
💛 - Coveralls

@varshaprasad96
create placeholder repositories
6fa063c 
Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
fabianvf
fabianvf approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2021
@fabianvf fabianvf merged commit 7cb02dd into operator-framework:main Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianvf fabianvf fabianvf approved these changes

Assignees

@fabianvf fabianvf

Labels
area/sdk lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@varshaprasad96 @coveralls @fabianvf