Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to Quarkus 2.13.1.Final & JOSDK extension 4.0.2 #104

Merged
merged 2 commits into from
Oct 7, 2022
Merged

chore: update to Quarkus 2.13.1.Final & JOSDK extension 4.0.2 #104

merged 2 commits into from
Oct 7, 2022

Conversation

metacosm
Copy link
Collaborator

@metacosm metacosm commented Oct 6, 2022

No description provided.

@metacosm metacosm self-assigned this Oct 6, 2022
jmrodri
jmrodri approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
laxmikantbpandhare
laxmikantbpandhare requested changes Oct 6, 2022
View reviewed changes
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the test data as well just to be in sync with the changes made.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2022
@metacosm
Copy link
Collaborator Author

metacosm commented Oct 7, 2022

Could you please update the test data as well just to be in sync with the changes made.

Hmm, actually what is that test data supposed to accomplish if it needs to be manually updated?

@laxmikantbpandhare
Copy link
Member

Could you please update the test data as well just to be in sync with the changes made.

Hmm, actually what is that test data supposed to accomplish if it needs to be manually updated?

We can scaffold it as well in testdata. We just want it to sync with current changes.

@laxmikantbpandhare
Copy link
Member

in SDK, we have tests which verifies testdata with current changes which we don't have setup for java-operator-plugins

@laxmikantbpandhare
Copy link
Member

Created issue for the same - #105

laxmikantbpandhare
laxmikantbpandhare approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2022
@laxmikantbpandhare laxmikantbpandhare merged commit 2e24140 into main Oct 7, 2022
@metacosm
Copy link
Collaborator Author

metacosm commented Oct 7, 2022

Note that the more important issue is #75, until that's done, I don't think that we can claim to really validate what we output ;)

@metacosm metacosm deleted the update branch October 7, 2022 12:05
@laxmikantbpandhare
Copy link
Member

Note that the more important issue is #75, until that's done, I don't think that we can claim to really validate what we output ;)

@metacosm - agree with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@laxmikantbpandhare laxmikantbpandhare laxmikantbpandhare approved these changes

Assignees

@jmrodri jmrodri

@metacosm metacosm

@laxmikantbpandhare laxmikantbpandhare

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@metacosm @laxmikantbpandhare @jmrodri