Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition fix #1011

Merged
merged 5 commits into from
Mar 9, 2022
Merged

Race condition fix #1011

merged 5 commits into from
Mar 9, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Mar 9, 2022 •
edited
Loading

This should update to the approach that is equivalent to the one for 2.2.0.

@csviri csviri self-assigned this Mar 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

71.1% 71.1% Coverage
0.0% 0.0% Duplication

@csviri csviri marked this pull request as ready for review March 9, 2022 16:15
@csviri csviri requested a review from metacosm March 9, 2022 16:40
metacosm
metacosm approved these changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csviri csviri linked an issue Mar 9, 2022 that may be closed by this pull request
Race Condition with handling the updated resource after reconciliation. #1006
Closed
@csviri csviri merged commit acd9ec4 into main Mar 9, 2022
@csviri csviri deleted the race-condition-fix branch March 9, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race Condition with handling the updated resource after reconciliation.
2 participants
@csviri @metacosm