Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update example of registering an event source #2514

Merged
merged 1 commit into from
Aug 23, 2024
Merged

chore: update example of registering an event source #2514

merged 1 commit into from
Aug 23, 2024

Conversation

matteriben
Copy link
Contributor

@matteriben matteriben commented Aug 22, 2024 •
edited
Loading

Updated the example of registering an event source and also the link.

Previous example:

  • Returned List instead of Map
  • Used name configMapEventSource , but was apparently for Deployment
  • Had apparent copy/paste error around lines 508-509

Updated example:

  • Omits some details of the actual linked code
  • Increased indentation

@matteriben
chore: update example of registering an event source
9a74397 
Signed-off-by: Matt Riben <matt.riben@swirldslabs.com>
@matteriben matteriben force-pushed the chore/update-example-of-registering-an-event-source branch from 211e064 to 9a74397 Compare August 22, 2024 22:47
metacosm
metacosm approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@metacosm metacosm merged commit f8e965c into operator-framework:main Aug 23, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

@andreaTP andreaTP Awaiting requested review from andreaTP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteriben @metacosm