Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloner interface for Custom Resource instead of ObjectMapper #611

Merged
merged 10 commits into from
Oct 20, 2021
Merged

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Oct 18, 2021

No description provided.

@csviri csviri changed the title Cloner Cloner interface for Custom Resource instead of ObjectMapper Oct 18, 2021
@csviri csviri linked an issue Oct 18, 2021 that may be closed by this pull request
@metacosm
Copy link
Collaborator

Please rebase your PR so that all commits follow the conventional commit message format: https://www.conventionalcommits.org/en/v1.0.0/

@csviri
Copy link
Collaborator Author

csviri commented Oct 20, 2021

Please rebase your PR so that all commits follow the conventional commit message format: https://www.conventionalcommits.org/en/v1.0.0/

When doing the squash will actually put there just one meaningful messages following this convention.

@csviri csviri marked this pull request as ready for review October 20, 2021 07:07
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs to be rebased against the other branches' changes.

# Conflicts:
#	operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/DefaultEventHandler.java
#	operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/internal/CustomResourceEventSource.java
#	operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/internal/OnceWhitelistEventFilterEventFilter.java
@csviri csviri merged commit 892880b into v2 Oct 20, 2021
@csviri csviri deleted the cloner branch October 20, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic cloner interface
2 participants