Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: config override with metrics #840

Merged
merged 2 commits into from
Jan 17, 2022
Merged

fix: config override with metrics #840

merged 2 commits into from
Jan 17, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Jan 17, 2022

Fixes a bug with Configuration Overrides, in order to be able to override metrics. Also adds logging metrics to MySQL sample.

@csviri csviri self-assigned this Jan 17, 2022
@csviri csviri requested a review from metacosm January 17, 2022 09:50
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

22.2% 22.2% Coverage
0.0% 0.0% Duplication

@csviri
Copy link
Collaborator Author

csviri commented Jan 17, 2022

@metacosm I would release 2.0.1 after this is merged, or maybe end of the day, since the other PR fixes a serious bug:
#837

@csviri csviri merged commit 5a7d1be into main Jan 17, 2022
@csviri csviri deleted the sample-and-config-override-fix branch January 17, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csviri @metacosm