Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail explicitly if current namespace is requested but not available #900

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

metacosm
Copy link
Collaborator

@metacosm metacosm commented Feb 2, 2022

Fixes #897

@metacosm metacosm self-assigned this Feb 2, 2022
@metacosm metacosm requested a review from csviri February 2, 2022 10:17
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csviri
Copy link
Collaborator

csviri commented Feb 2, 2022

The sonar should not be skipped here.

cc @andreaTP

@andreaTP
Copy link
Collaborator

andreaTP commented Feb 2, 2022

@csviri you are right, I messed up the key, it "should" be:

github.event.pull_request.head.repo.owner.login

instead of:

github.event.pull_request.repository_owner

here: https://github.com/java-operator-sdk/java-operator-sdk/blob/14403fb1908773afe439835406970c2f1bcf5a0b/.github/workflows/sonar.yml#L18

Do you mind to check?

(ref: https://git.luolix.topmunity/t/get-the-head-repository-name-in-prs/17669/2 )

@csviri
Copy link
Collaborator

csviri commented Feb 2, 2022

Do you mind to check?

Sure, thx for the hint, will fix it. thx @andreaTP

@metacosm metacosm merged commit e0f7b10 into main Feb 2, 2022
@metacosm metacosm deleted the fix-npe-main branch February 2, 2022 15:08
@metacosm
Copy link
Collaborator Author

metacosm commented Feb 2, 2022

Well, it turns out that this "feature" might actually break the Quarkus extension… 😓

@metacosm
Copy link
Collaborator Author

metacosm commented Feb 2, 2022

Would be nice to set up some sort of CI that would check the quarkus extension for each PR we create it, similarly to what the Quarkus CI does…

@andreaTP
Copy link
Collaborator

andreaTP commented Feb 2, 2022

NDR: the Quarkus CI uses the "star" ⭐ action as an hook for running external GH actions

@metacosm
Copy link
Collaborator Author

metacosm commented Feb 2, 2022

Well, it turns out that this "feature" might actually break the Quarkus extension… 😓

Actually, it's not breaking so all good. Setting up CI should still be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE when initializing the operator if there's no explicit namespace set in Kubernetes config
3 participants