-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fail explicitly if current namespace is requested but not available #900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The sonar should not be skipped here. cc @andreaTP |
@csviri you are right, I messed up the key, it "should" be:
instead of:
Do you mind to check? (ref: https://git.luolix.topmunity/t/get-the-head-repository-name-in-prs/17669/2 ) |
Sure, thx for the hint, will fix it. thx @andreaTP |
Well, it turns out that this "feature" might actually break the Quarkus extension… 😓 |
Would be nice to set up some sort of CI that would check the quarkus extension for each PR we create it, similarly to what the Quarkus CI does… |
NDR: the Quarkus CI uses the "star" ⭐ action as an hook for running external GH actions |
Actually, it's not breaking so all good. Setting up CI should still be done. |
Fixes #897