Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: share more code #910

Merged
merged 1 commit into from
Feb 4, 2022
Merged

refactor: share more code #910

merged 1 commit into from
Feb 4, 2022

Conversation

metacosm
Copy link
Collaborator

@metacosm metacosm commented Feb 4, 2022

No description provided.

@metacosm metacosm self-assigned this Feb 4, 2022
@metacosm metacosm requested a review from csviri February 4, 2022 14:09
@sonarcloud
Copy link

sonarcloud bot commented Feb 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@andreaTP
Copy link
Collaborator

andreaTP commented Feb 4, 2022

LGTM, thanks! 👍

@metacosm
Copy link
Collaborator Author

metacosm commented Feb 4, 2022

LGTM, thanks! 👍

No, thank you for the initial work! 😁

Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metacosm metacosm merged commit 817f8ca into main Feb 4, 2022
@metacosm metacosm deleted the test branch February 4, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants