Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweet on release! #913

Merged
merged 6 commits into from
Feb 17, 2022
Merged

Tweet on release! #913

merged 6 commits into from
Feb 17, 2022

Conversation

RishiKumarRay
Copy link
Contributor

@csviri
Copy link
Collaborator

csviri commented Feb 7, 2022

@RishiKumarRay we already have a relase workflow, I think this should be added rather as a next action after the release is done. So we tweet only if the release not failed. After this step:
https://github.com/java-operator-sdk/java-operator-sdk/blob/d38d694e1a7775e1374b8e71c136dd4cb6002283/.github/workflows/release.yml#L28

@RishiKumarRay
Copy link
Contributor Author

on:
release:
types: [Release Maven package]
@csviri you mean this ?

@csviri
Copy link
Collaborator

csviri commented Feb 7, 2022

I mean that this step:

 - uses: Eomm/why-don-t-you-tweet@v1
        # We don't want to tweet if the repository is not a public one
        if: ${{ !github.event.repository.private }}
        with:
          # GitHub event payload
          # https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#release
          tweet-message: "New ${{ github.event.repository.name }} release ${{ github.event.release.tag_name }}! Try it will it is HOT! ${{ github.event.release.html_url }} #release"
        env:
          # Get your tokens from https://developer.twitter.com/apps
          TWITTER_CONSUMER_API_KEY: ${{ secrets.TWITTER_CONSUMER_API_KEY }}
          TWITTER_CONSUMER_API_SECRET: ${{ secrets.TWITTER_CONSUMER_API_SECRET }}
          TWITTER_ACCESS_TOKEN: ${{ secrets.TWITTER_ACCESS_TOKEN }}
          TWITTER_ACCESS_TOKEN_SECRET: ${{ secrets.TWITTER_ACCESS_TOKEN_SECRET }}
          

should go after this:
https://github.com/java-operator-sdk/java-operator-sdk/blob/d38d694e1a7775e1374b8e71c136dd4cb6002283/.github/workflows/release.yml#L28

In the same flow.

@RishiKumarRay
Copy link
Contributor Author

@csviri can you check now hope i have done in right way now

@csviri
Copy link
Collaborator

csviri commented Feb 7, 2022

@csviri can you check now hope i have done in right way now

thx, better just this is the update-working-version job, what happens parallel to the publish, so if you could move it to the last step to publish that would be perfect.

@RishiKumarRay
Copy link
Contributor Author

@csviri move to line number 15 in release.yml? am i right ?

@csviri
Copy link
Collaborator

csviri commented Feb 7, 2022

@csviri move to line number 15 in release.yml? am i right ?

to line 36.

@RishiKumarRay
Copy link
Contributor Author

@csviri oh yes , thanks i have updated this please review

Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csviri
Copy link
Collaborator

csviri commented Feb 7, 2022

will manage the account then merge, thx! @RishiKumarRay

@RishiKumarRay
Copy link
Contributor Author

Yeah sure @csviri thanks

@csviri csviri linked an issue Feb 7, 2022 that may be closed by this pull request
@csviri csviri self-assigned this Feb 8, 2022
@csviri csviri merged commit 7d1ecca into operator-framework:main Feb 17, 2022
@metacosm
Copy link
Collaborator

Woot! Thank you. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweet on release!
3 participants