Josdk 1.9.1 #2
Josdk 1.9.1 #2
Conversation
daniellavoie
commented
Jun 5, 2021
daniellavoie
commented
- Upgrades to josdk 1.9.0
- Cleanup dependency management and duplicate properties in poms
- Moved starter-test into the project to fix circular dependencies
- Upgrade fabric8 to 5.4.1 to support TLSv1 deprecation from latest JDKs
- Added maven wrapper
* Upgrades to josdk 1.9.0 * Cleanup dependency management and duplicate properties in poms * Moved starter-test into the project to fix circular dependencies Fixes operator-framework#1
| </parent> | ||
|
|
||
| <name>Java Operator SDK Spring Boot Starter Test</name> | ||
| <description>Spring Boot starter for the Java Operator SDK</description> |
There was a problem hiding this comment.
I think you need to adjust the description here to mention that this is the test starter…
| @@ -61,25 +60,23 @@ public boolean checkCRDAndValidateLocalModel() { | |||
| @ConditionalOnMissingBean(Operator.class) | |||
| public Operator operator( | |||
| KubernetesClient kubernetesClient, | |||
| List<ResourceController<?>> resourceControllers, | |||
| Optional<ObjectMapper> objectMapper) { | |||
There was a problem hiding this comment.
Why did you remove the option to configure the ObjectMapper?
There was a problem hiding this comment.
The ObjectMapper constructor option was removed with 1.9.0. I may have overlooked potential other new constructor options.
There was a problem hiding this comment.
Ah, yes, sorry! The ObjectMapper is now configured via the ConfigurationService.
|
Thank you for taking on that effort! I assume we will need to delete the |
|
Yes, |
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
|
Hi @daniellavoie, any chance we could complete this work and get it merged soon? |
| <surefire.version>3.0.0-M5</surefire.version> | ||
| <fabric8-client.version>5.4.1</fabric8-client.version> |
|
@daniellavoie any chances to merge this PR? |
