Skip to content

Commit

Permalink
Fixes kind cluster cleanup in e2e make target
Browse files Browse the repository at this point in the history
Currently we have `kind-cluster-cleanup` as a dependency
in `kind-cluster` target. Since `make` only builds a target
once this means that `e2e` target performs cleanup
before creating a new cluster and skips cleanup at the end
leaving cluster hanging around.

With this change, `make e2e` will be failing on cluster creation,
if a cluster with the same name already exists, but the failure
message will clearly indicate the issue.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
  • Loading branch information
m1kola committed Jul 27, 2023
1 parent 3c55b14 commit 051cb1c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ e2e: run kind-load-test-artifacts test-e2e kind-cluster-cleanup ## Run e2e test
kind-load: $(KIND) ## Loads the currently constructed image onto the cluster
$(KIND) load docker-image $(IMG) --name $(KIND_CLUSTER_NAME)

kind-cluster: $(KIND) kind-cluster-cleanup ## Standup a kind cluster
kind-cluster: $(KIND) ## Standup a kind cluster
$(KIND) create cluster --name ${KIND_CLUSTER_NAME}
$(KIND) export kubeconfig --name ${KIND_CLUSTER_NAME}

Expand Down

0 comments on commit 051cb1c

Please sign in to comment.