Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
  • Loading branch information
rashmigottipati committed May 14, 2024
1 parent 67cc278 commit 224d139
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions api/v1alpha1/clusterextension_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,19 +93,19 @@ type CRDUpgradeSafetyPreflightConfig struct {
//+kubebuilder:validation:Enum:=Enabled;Disabled
//+kubebuilder:default:=Enabled
//+kubebuilder:Optional
Mode Mode `json:"mode,omitempty"`
CRDUpgradeSafetyMode CRDUpgradeSafetyMode `json:"crdUpgradeSafetyMode,omitempty"`
}

type Mode string
type CRDUpgradeSafetyMode string

const (
// CRDUpgradeSafetyPreflightConfigEnabled represents the default state for the
// CRDUpgradeSafetyModeEnabled represents the default state for the
// CRD Upgrade Safety validations by setting it to "Enabled".
CRDUpgradeSafetyPreflightConfigEnabled Mode = "Enabled"
CRDUpgradeSafetyModeEnabled CRDUpgradeSafetyMode = "Enabled"

// CRDUpgradeSafetyPreflightConfigDisabled represents the option for the
// CRDUpgradeSafetyModeDisabled represents the option for the
// CRD Upgrade Safety validations to be disabled by setting it to "Disabled".
CRDUpgradeSafetyPreflightConfigDisabled Mode = "Disabled"
CRDUpgradeSafetyModeDisabled CRDUpgradeSafetyMode = "Disabled"
)

const (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ spec:
that sets the CRD Upgrade Safety validations to either Enabled/Disabled.
By default, this is set to "Enabled".
properties:
mode:
crdUpgradeSafetyMode:
default: Enabled
enum:
- Enabled
Expand Down

0 comments on commit 224d139

Please sign in to comment.