Fix error message for unknown unpack state

Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
operator-framework · Jun 11, 2024 · 6bc072f · 6bc072f
1 parent f9cca2a
commit 6bc072f
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/internal/controllers/clusterextension_controller.go b/internal/controllers/clusterextension_controller.go
@@ -263,8 +263,9 @@ func (r *ClusterExtensionReconciler) reconcile(ctx context.Context, ext *ocv1alp
 		}
 		setStatusUnpacked(ext, fmt.Sprintf("unpack successful: %v", unpackResult.Message))
 	default:
-		setStatusUnpackFailed(ext, fmt.Sprintf("unpack successful: %v", unpackResult.Message))
-		return ctrl.Result{}, fmt.Errorf("unexpected unpack status: %v", err)
+		setStatusUnpackFailed(ext, "unexpected unpack status")
+		// We previously exit with a failed status if error is not nil.
+		return ctrl.Result{}, fmt.Errorf("unexpected unpack status: %v", unpackResult.Message)
 	}
 
 	bundleFS, err := r.Storage.Load(ctx, ext)