Update related TODO in ClusterExtension controller

Signed-off-by: Brett Tofel <btofel@redhat.com>
operator-framework · Jul 3, 2024 · e0ff96d · e0ff96d
1 parent b6a1109
commit e0ff96d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/internal/controllers/clusterextension_controller.go b/internal/controllers/clusterextension_controller.go
@@ -278,8 +278,7 @@ func (r *ClusterExtensionReconciler) reconcile(ctx context.Context, ext *ocv1alp
 
 		return ctrl.Result{}, nil
 	case rukpaksource.StateUnpacked:
-		// TODO: Add finalizer to clean the stored bundles, after https://github.com/operator-framework/rukpak/pull/897
-		// merges.
+		// TODO: https://github.com/operator-framework/rukpak/pull/897 merged, add finalizer to clean the stored bundles
 		if err := r.Storage.Store(ctx, ext, unpackResult.Bundle); err != nil {
 			setStatusUnpackFailed(ext, err.Error())
 			return ctrl.Result{}, err

diff --git a/internal/controllers/common_controller.go b/internal/controllers/common_controller.go
@@ -118,7 +118,6 @@ func setStatusUnpackFailed(ext *ocv1alpha1.ClusterExtension, message string) {
 	})
 }
 
-// TODO: verify if we need to update the installBundle status or leave it as is.
 func setStatusInstallFalseUnpackFailed(ext *ocv1alpha1.ClusterExtension, message string) {
 	ext.Status.InstalledBundle = nil
 	apimeta.SetStatusCondition(&ext.Status.Conditions, metav1.Condition{