Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .status.resolution field #1306

Closed
Tracked by #740
everettraven opened this issue Sep 24, 2024 · 1 comment · Fixed by #1315
Closed
Tracked by #740

Remove .status.resolution field #1306

everettraven opened this issue Sep 24, 2024 · 1 comment · Fixed by #1315
Assignees
@LalatenduMohanty
Labels
epic/v1-api v1.0 Issues related to the initial stable release of OLMv1

Comments

@everettraven
Copy link
Contributor

everettraven commented Sep 24, 2024 •
edited
Loading

The core maintainers chatted and determined that there does not exist a concrete use case for the .status.resolution field. As such, this field should be removed and the resolution information appropriately conveyed in any status condition messages representing an error after resolution has been successful but before installation has been successful.

Acceptance Criteria

  • .status.resolution field is removed from the ClusterExtension API
  • resolution information is included in status condition messages where necessary. Namely when an error occurs between successful resolution and successful installation
  • Tests are updated as necessary to no longer use the .status.resolution field in assertions
@everettraven everettraven mentioned this issue Sep 24, 2024
Open
20 tasks
@everettraven everettraven added v1.0 Issues related to the initial stable release of OLMv1 epic/v1-api labels Sep 24, 2024
@LalatenduMohanty LalatenduMohanty self-assigned this Sep 24, 2024
LalatenduMohanty added a commit to LalatenduMohanty/operator-controller that referenced this issue Sep 25, 2024
@LalatenduMohanty
Remove status.resolution
1c21642 
Fixes: operator-framework#1306

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@everettraven
Copy link
Contributor Author

@LalatenduMohanty just a heads up that I just added a description to this issue

LalatenduMohanty added a commit to LalatenduMohanty/operator-controller that referenced this issue Sep 26, 2024
@LalatenduMohanty
Remove status.resolution
2e39ba5 
Fixes operator-framework#1306

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@LalatenduMohanty LalatenduMohanty mentioned this issue Sep 26, 2024
Merged
4 tasks
LalatenduMohanty added a commit to LalatenduMohanty/operator-controller that referenced this issue Sep 27, 2024
@LalatenduMohanty
Remove status.resolution
fe6f857 
Fixes operator-framework#1306

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty added a commit to LalatenduMohanty/operator-controller that referenced this issue Sep 27, 2024
@LalatenduMohanty
Remove status.resolution
bd351e2 
Fixes operator-framework#1306

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty added a commit to LalatenduMohanty/operator-controller that referenced this issue Sep 27, 2024
@LalatenduMohanty
Remove status.resolution
0c8c1e2 
Fixes operator-framework#1306

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty added a commit to LalatenduMohanty/operator-controller that referenced this issue Sep 27, 2024
@LalatenduMohanty
Remove status.resolution
c5cfda2 
Fixes operator-framework#1306

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty added a commit to LalatenduMohanty/operator-controller that referenced this issue Sep 27, 2024
@LalatenduMohanty
Remove status.resolution
8991720 
Fixes operator-framework#1306

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty added a commit to LalatenduMohanty/operator-controller that referenced this issue Sep 27, 2024
@LalatenduMohanty
Remove status.resolution
e29c5e0 
Fixes operator-framework#1306

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty added a commit to LalatenduMohanty/operator-controller that referenced this issue Sep 27, 2024
@LalatenduMohanty
Remove status.resolution
26bdc55 
Fixes operator-framework#1306

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty added a commit to LalatenduMohanty/operator-controller that referenced this issue Sep 30, 2024
@LalatenduMohanty
Remove status.resolution
4e94765 
Fixes operator-framework#1306

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty added a commit to LalatenduMohanty/operator-controller that referenced this issue Sep 30, 2024
@LalatenduMohanty
Remove status.resolution
fb9f928 
Fixes operator-framework#1306

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty added a commit to LalatenduMohanty/operator-controller that referenced this issue Sep 30, 2024
@LalatenduMohanty
Remove status.resolution
0d52cf5 
Fixes operator-framework#1306

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty added a commit to LalatenduMohanty/operator-controller that referenced this issue Sep 30, 2024
@LalatenduMohanty
Remove status.resolution
2b3957e 
Fixes operator-framework#1306

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty added a commit to LalatenduMohanty/operator-controller that referenced this issue Sep 30, 2024
@LalatenduMohanty
Remove status.resolution
917303e 
Fixes operator-framework#1306

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
github-merge-queue bot pushed a commit that referenced this issue Oct 1, 2024
@LalatenduMohanty
⚠️ Remove status.resolution (#1315)
fba8473 
* Remove status.resolution

Fixes #1306

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

* Improving the unit test code readability

replacing below code with require.NotNil(ct, cond)
    ```
    if !assert.NotNil(ct, cond) {
                            return
                    }
    ```

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

---------

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LalatenduMohanty LalatenduMohanty

Labels
epic/v1-api v1.0 Issues related to the initial stable release of OLMv1
Projects
OLM v1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⚠️ Remove status.resolution LalatenduMohanty/operator-controller
2 participants
@LalatenduMohanty @everettraven