Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for ensuring that existing required fields can be marked as optional #715

Closed
Tracked by #657
rashmigottipati opened this issue Mar 25, 2024 · 3 comments
Assignees
Labels
epic/crd-upgrade-safety Marks an issue as part of the CRD Upgrade Safety epic

Comments

@rashmigottipati
Copy link
Member

This builds on top of #666 and focuses on adding a valid check to ensure that existing required fields can be marked as optional in a CustomResourceDefinition schema.

If the proposal for adding this functionality to carvel-dev/kapp has been accepted prior to starting this work, all changes should be made against carvel-dev/kapp, otherwise the changes should be made against https://github.com/everettraven/kapp/tree/feature/crd-upgrade-safety-preflight

@everettraven
Copy link
Contributor

Proposal merged and work is now being tracked in carvel-dev/kapp. This is now a tracker for carvel-dev/kapp#915

@rashmigottipati
Copy link
Member Author

Created a PR (in code review) for this in kapp: carvel-dev/kapp#933

@rashmigottipati
Copy link
Member Author

Closing as PR merged in kapp upstream: carvel-dev/kapp#933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/crd-upgrade-safety Marks an issue as part of the CRD Upgrade Safety epic
Projects
Status: Done
Development

No branches or pull requests

2 participants