Add handling of updates to required fields to the CRD Upgrade Safety preflight check #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everettraven
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Besides a minor nit on the error message for adding required fields when there were previously none this looks great to me! Great work @rashmigottipati !
test/e2e/preflight_crdupgradesafety_invalid_field_change_requiredfield_added_test.go
Show resolved
Hide resolved
...reflight_crdupgradesafety_invalid_field_change_requiredfield_added_when_none_existed_test.go
Show resolved
Hide resolved
...reflight_crdupgradesafety_invalid_field_change_requiredfield_added_when_none_existed_test.go
Outdated
Show resolved
Hide resolved
rashmigottipati
force-pushed
the
feature/add-requiredfield-check
branch
from
e77c330
to
97bfff2
Compare
|
@praveenrewar Thanks for reviewing the PR. Addressed the review feedback. Will squash commits after approval/lgtm. |
…preflight check Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
rashmigottipati
force-pushed
the
feature/add-requiredfield-check
branch
from
97bfff2
to
fcb5fbe
Compare
|
Rebased and squashed the commits. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a validation check to ensure that existing required fields can be marked as optional in a CRD schema:
Which issue(s) this PR fixes:
Fixes #915
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: