-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handling of updates to required fields to the CRD Upgrade Safety preflight check #933
Add handling of updates to required fields to the CRD Upgrade Safety preflight check #933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides a minor nit on the error message for adding required fields when there were previously none this looks great to me! Great work @rashmigottipati !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor changes. Looks good otherwise.
test/e2e/preflight_crdupgradesafety_invalid_field_change_requiredfield_added_test.go
Show resolved
Hide resolved
...reflight_crdupgradesafety_invalid_field_change_requiredfield_added_when_none_existed_test.go
Show resolved
Hide resolved
...reflight_crdupgradesafety_invalid_field_change_requiredfield_added_when_none_existed_test.go
Outdated
Show resolved
Hide resolved
e77c330
to
97bfff2
Compare
@praveenrewar Thanks for reviewing the PR. Addressed the review feedback. Will squash commits after approval/lgtm. |
…preflight check Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
97bfff2
to
fcb5fbe
Compare
Rebased and squashed the commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What this PR does / why we need it:
This PR adds a validation check to ensure that existing required fields can be marked as optional in a CRD schema:
Which issue(s) this PR fixes:
Fixes #915
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: