Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit testing of reconcile() function. #879

Open
Tracked by #950
tmshort opened this issue May 21, 2024 · 1 comment
Open
Tracked by #950

Improve unit testing of reconcile() function. #879

tmshort opened this issue May 21, 2024 · 1 comment
Assignees

Comments

@tmshort
Copy link
Contributor

tmshort commented May 21, 2024

As discussed in the meeting earlier today, I'd like to see us move to a model where this functions is a bit easier to unit test by creating logical abstractions where they make sense and mocking them during unit testing.

Totally fine with this being a follow-up, just commenting to track the recommendation :)

Originally posted by @everettraven in #846 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants