Meta: Helm Integration follow ups

[varshaprasad96]

This issue tracks the follow ups which are in queue after the helm integration feature is merged to main: #846

Codebase:

• Limit the number of unpack re-tries in the reconciler: Limit the number of unpack retries #882
• Bump rukpak version to use direct image registry client, instead of spinning up an unpack pod - [Helm integration] Follow up to #846 - change unpacking to direct image registry client approach #853 (⚠️ Bump rukpak #905)
• Modify reconciler to use sets pkg from sig-apimachinery while watching dynamic clients: Use k8s.io/apimachinery/pkg/util/sets package #881
• Remove handler implementation from Operator-controller, instead use the one from rukpak: [Helm integration] Remove handler implementation from Operator controller and reuse from Rukpak #867
• Address error types in reconciler returns: ✨ Use error type rather than strings #878
• Review and remove the use of rukpak API types: Use Operator Controller types vs. Rukpak types #896
• Remove annotations, add APIs for certificates Remove bundle.connection.config/insecureSkipTLSVerify annotation #921
• Fix: finalizers not set on ClusterExtension Fix: finalizers not set on ClusterExtension #942
• [Helm Integration] Evaluate if we need to store unpacked bundles in cache. #869

Tests:

• Modify reconciler to mock GetInstalledBundle: 🌱 Change global var GetInstalledBundle to interface #899
• Add unit tests in the reconciler for steps after unpack: Improve unit testing of reconcile() function. #879

Moved to #733

• Evaluate the use of Operator conditions in the reconciler: Evaluate the use of conditions and reasoning in cluster extension controller #893

[joelanford]

Another thing I just found. We setup finalizers in main.go, but then don't actually set them on the reconciler or call Finalize during reconciliation. I tried updating to do these things, but then the controller started panic-ing because the finalizer expects to finalize a BundleDeployment, but we are now trying to finalize a ClusterExtension.

I added an item to the checklist in the description (#942)

[tmshort]

@joelanford should this be considered an epic, in place of or addition to #733?