Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Bump rukpak #905

Merged
merged 17 commits into from
Jun 12, 2024
Merged

⚠️ Bump rukpak #905

merged 17 commits into from
Jun 12, 2024

Conversation

varshaprasad96
Copy link
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 3, 2024 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 6bc072f
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6668682982c3820008340f1b
😎 Deploy Preview https://deploy-preview-905--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dtfranz
dtfranz reviewed Jun 3, 2024
View reviewed changes
Dockerfile Show resolved Hide resolved
dtfranz
dtfranz reviewed Jun 3, 2024
View reviewed changes
Makefile Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.38%. Comparing base (40e1bac) to head (6bc072f).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/manager/main.go 30.00% 4 Missing and 3 partials ⚠️
...nternal/controllers/clusterextension_controller.go 66.66% 3 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
+ Coverage   73.54%   77.38%   +3.83%     
==========================================
  Files          18       17       -1     
  Lines        1221     1163      -58     
==========================================
+ Hits          898      900       +2     
+ Misses        248      183      -65     
- Partials       75       80       +5
Flag Coverage Δ
e2e 57.17% <44.00%> (-3.02%) ⬇️
unit 50.98% <24.00%> (+2.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort tmshort mentioned this pull request Jun 4, 2024
Closed
4 tasks
@tmshort tmshort mentioned this pull request Jun 5, 2024
Merged
4 tasks
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2024
@varshaprasad96 varshaprasad96 force-pushed the bump/rukpak branch 3 times, most recently from 32e223d to 9cae5f3 Compare June 6, 2024 15:50
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2024
@varshaprasad96 varshaprasad96 mentioned this pull request Jun 7, 2024
Open
11 tasks
varshaprasad96 and others added 8 commits June 7, 2024 14:54
@varshaprasad96 @tmshort
Bump rukpak
e2a779a
@varshaprasad96 @tmshort
debugging tests
5652656 
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@tmshort
Use tar for manifests
6a671e8 
Signed-off-by: Todd Short <tshort@redhat.com>
@varshaprasad96 @tmshort
fix e2e
9a939bc 
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@tmshort
Remove unpack
9724c1d 
Signed-off-by: Todd Short <tshort@redhat.com>
@varshaprasad96 @tmshort
rebase with main
96ffa18 
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@tmshort
Fix webhooks package name and remove unstructured
9a10bb3 
Make the webhooks package name consistent with oterhs
Revert the use of unstructured

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
ext-dev-e2e passes
6e398b1 
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort changed the title Bump rukpak ⚠️ Bump rukpak Jun 7, 2024
tmshort and others added 4 commits June 10, 2024 10:49
@tmshort
Additional fixes from reviews
105c13d 
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
Remove DNS_NAME
a56f3cd 
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
Put back InsecureSkipTLSVerify: true for now
00dbc12 
Signed-off-by: Todd Short <tshort@redhat.com>
@varshaprasad96
Add annotation to set insecureSkipTLSVerify
1ed0f20 
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@m1kola m1kola mentioned this pull request Jun 11, 2024
Merged
4 tasks
m1kola
m1kola reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some comment threads which are open. Apart from that - looks good to me.

@tmshort
Rename back to package-with-webhooks
5097525 
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
Used labeled rukpak
f9cca2a 
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
Copy link
Contributor

tmshort commented Jun 11, 2024

Made a couple (small) commits to hopefully address the last of the comments... @m1kola ?

@varshaprasad96
Fix error message for unknown unpack state
6bc072f 
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@varshaprasad96
Copy link
Member Author

@m1kola looks like all the comments have been addressed. Could you please provide a lgtm if all is well.

@tmshort tmshort added this pull request to the merge queue Jun 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2024
@tmshort tmshort added this pull request to the merge queue Jun 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2024
@tmshort tmshort added this pull request to the merge queue Jun 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2024
@tmshort
Copy link
Contributor

tmshort commented Jun 11, 2024 

GitHub Actions has encountered an internal error when running your job.

@tmshort tmshort added this pull request to the merge queue Jun 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2024
@m1kola m1kola added this pull request to the merge queue Jun 12, 2024
Merged via the queue into operator-framework:main with commit 66a063b Jun 12, 2024
16 of 17 checks passed
@tmshort tmshort mentioned this pull request Jun 13, 2024
Closed
@tmshort tmshort mentioned this pull request Jun 27, 2024
Closed
@skattoju skattoju mentioned this pull request Jul 2, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford left review comments

@bentito bentito bentito left review comments

@dtfranz dtfranz dtfranz left review comments

@tmshort tmshort tmshort left review comments

@m1kola m1kola m1kola approved these changes

@everettraven everettraven everettraven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@varshaprasad96 @m1kola @tmshort @joelanford @bentito @dtfranz @everettraven @openshift-merge-robot