Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Change global var GetInstalledBundle to interface #899

Merged
merged 1 commit into from
May 30, 2024

Conversation

bentito
Copy link
Contributor

@bentito bentito commented May 30, 2024

Description

Follow on to the helm-poc changes:

We'd like to not have a global variable for GetInstalledBundle, but instead an easier to test interface.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Brett Tofel <btofel@redhat.com>
@bentito bentito requested a review from a team as a code owner May 30, 2024 19:57
Copy link

netlify bot commented May 30, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 93b05e0
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6658da407ed49e0008c6a218
😎 Deploy Preview https://deploy-preview-899--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.21%. Comparing base (0058054) to head (93b05e0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #899      +/-   ##
==========================================
- Coverage   77.21%   76.21%   -1.01%     
==========================================
  Files          17       17              
  Lines        1176     1177       +1     
==========================================
- Hits          908      897      -11     
- Misses        189      202      +13     
+ Partials       79       78       -1     
Flag Coverage Δ
e2e 58.19% <100.00%> (-1.67%) ⬇️
unit 58.02% <50.00%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bentito bentito added this pull request to the merge queue May 30, 2024
Merged via the queue into operator-framework:main with commit b282b12 May 30, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants