Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm integration] Remove handler implementation from Operator controller and reuse from Rukpak #867

Closed
varshaprasad96 opened this issue May 16, 2024 · 2 comments
Assignees

Comments

@varshaprasad96
Copy link
Member

Reuse the handler in Rukpak to covert registryV1 to chart: https://github.com/operator-framework/rukpak/blob/19e1839a4d6bb44a15bfcd8f876b5780ecdbc445/internal/provisioner/registry/registry.go#L22

The only value from BD that it needs is spec.InstallName, which we can set from CE while creating a mock for BD in the controller:

bd := r.generateBundleDeploymentForUnpack(bundle.Image, ext)
.

This requires us to make handler code external.

@varshaprasad96 varshaprasad96 changed the title [Helm poc] Remove handler implementation from Operator controller and reuse from Rukpak [Helm integration] Remove handler implementation from Operator controller and reuse from Rukpak May 16, 2024
@makon57
Copy link
Contributor

makon57 commented Jun 7, 2024

/assign

@varshaprasad96
Copy link
Member Author

This issue has been addressed as a part of #928. Hence closing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants