[resolution pt.7] resolver integration #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perdasilva
force-pushed
the
resolution_pt7_resolver_integration
branch
2 times, most recently
from
3c860df
to
36c8a56
Compare
openshift-merge-robot
added
the
needs-rebase
perdasilva
force-pushed
the
resolution_pt7_resolver_integration
branch
from
36c8a56
to
3e231aa
Compare
openshift-merge-robot
removed
the
needs-rebase
awgreene
approved these changes
Jan 26, 2023
Comment on lines
+130
to
+142
| for _, operator := range operatorList.Items { | ||
| apimeta.SetStatusCondition(&operator.Status.Conditions, metav1.Condition{ | ||
| Type: operatorsv1alpha1.TypeReady, | ||
| Status: status, | ||
| Reason: reason, | ||
| Message: message, | ||
| ObservedGeneration: op.GetGeneration(), | ||
| }) | ||
| if varID, ok := packageVariableIDMap[operator.Spec.PackageName]; ok { | ||
| operator.Status.BundlePath = varID | ||
| } | ||
| if err := r.Client.Status().Update(ctx, &operator); err != nil { | ||
| return ctrl.Result{}, err | ||
| } | ||
| } |
There was a problem hiding this comment.
We may want to consider if we should update each of the operator CR's status here or if we should just retrigger the reconciler for each of them.
There was a problem hiding this comment.
I'll follow this up with another PR where I update deppy and how we handle the Solution struct changes
Signed-off-by: perdasilva <perdasilva@redhat.com>
Signed-off-by: perdasilva <perdasilva@redhat.com>
perdasilva
force-pushed
the
resolution_pt7_resolver_integration
branch
from
3e231aa
to
f75647a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the solver with the reconciler. It also update the Operator API to include a
BundlePathon Operator.Status