Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Service Account requirement to ClusterExtension #1011

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

makon57
Copy link
Contributor

@makon57 makon57 commented Jul 5, 2024

Description

This PR solves Issue #971 - Add new required field to ClusterExtension spec for users to reference a ServiceAccount

  • Created new required 'Service Account' field in ClusterExtensionSpec
  • Added Service Account to unit tests
  • Added Service Account to e2e test

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2024
Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit c6560b4
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/668c829771d49d00085de382
😎 Deploy Preview https://deploy-preview-1011--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@makon57 makon57 force-pushed the add-sa2ce branch 2 times, most recently from 4b8ce19 to 72cae75 Compare July 5, 2024 19:20
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.57%. Comparing base (235e3d4) to head (c6560b4).
Report is 1 commits behind head on main.

Files Patch % Lines
api/v1alpha1/zz_generated.deepcopy.go 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1011      +/-   ##
==========================================
- Coverage   78.05%   77.57%   -0.48%     
==========================================
  Files          18       18              
  Lines        1253     1262       +9     
==========================================
+ Hits          978      979       +1     
- Misses        193      201       +8     
  Partials       82       82              
Flag Coverage Δ
e2e 56.31% <11.11%> (-0.35%) ⬇️
unit 53.09% <0.00%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…sions

Signed-off-by: Manna Kong <mkong@redhat.com>
@makon57 makon57 force-pushed the add-sa2ce branch 2 times, most recently from c6a3bd5 to 74f02ac Compare July 8, 2024 20:26
Signed-off-by: Manna Kong <mkong@redhat.com>
@everettraven everettraven marked this pull request as ready for review July 9, 2024 14:40
@everettraven everettraven requested a review from a team as a code owner July 9, 2024 14:40
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2024
@everettraven everettraven added this pull request to the merge queue Jul 9, 2024
Merged via the queue into operator-framework:main with commit feaeece Jul 9, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants