-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ mask helm conflict errors #1016
✨ mask helm conflict errors #1016
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
20887b3
to
73fdc37
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1016 +/- ##
==========================================
+ Coverage 72.63% 73.29% +0.66%
==========================================
Files 28 30 +2
Lines 1889 1951 +62
==========================================
+ Hits 1372 1430 +58
- Misses 381 384 +3
- Partials 136 137 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@perdasilva can you please add the results (logging) before and after the PR here. Which will help me better understand the difference in user experience. |
Went from:
To:
|
@joelanford mentioned that this logging is also not right because it does not the point right root cause to the user. |
fe7be7f
to
5a2d772
Compare
it would be good to have an example..? or alternatively, here is the line. Please feel free to suggest a change |
5a2d772
to
5e42b17
Compare
7b5c4a8
to
671a0a9
Compare
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
671a0a9
to
d78e9a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>
Description
As part of #736 we'd like to mark helm errors when an installation fails due to conflict. This PR wraps the ActionClient interface we use to talk to helm and processes the errors returned give a set of programatic rules. So far, only the install conflict error translator is modeled
Reviewer Checklist