✨ expose a nodeport on kind cluster #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
acornett21
approved these changes
Jul 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
=======================================
Coverage 78.05% 78.05%
=======================================
Files 18 18
Lines 1253 1253
=======================================
Hits 978 978
Misses 193 193
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joelanford
reviewed
Jul 9, 2024
Comment on lines
+6
to
+10
| - containerPort: 30000 | ||
| hostPort: 30000 | ||
| listenAddress: "127.0.0.1" | ||
| protocol: tcp |
There was a problem hiding this comment.
Add a comment here as a breadcrumb if we change image registry stuff in the future?
Suggested change
| - containerPort: 30000 | |
| hostPort: 30000 | |
| listenAddress: "127.0.0.1" | |
| protocol: tcp | |
| # e2e image registry service's NodePort | |
| - containerPort: 30000 | |
| hostPort: 30000 | |
| listenAddress: "127.0.0.1" | |
| protocol: tcp |
There was a problem hiding this comment.
Done. Thanks for catching that.
Signed-off-by: yashoza19 <yoza@redhat.com>
joelanford
approved these changes
Jul 9, 2024
perdasilva
pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Aug 13, 2024
Signed-off-by: yashoza19 <yoza@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewer Checklist