-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ expose a nodeport on kind cluster #1021
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
=======================================
Coverage 78.05% 78.05%
=======================================
Files 18 18
Lines 1253 1253
=======================================
Hits 978 978
Misses 193 193
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- containerPort: 30000 | ||
hostPort: 30000 | ||
listenAddress: "127.0.0.1" | ||
protocol: tcp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment here as a breadcrumb if we change image registry stuff in the future?
- containerPort: 30000 | |
hostPort: 30000 | |
listenAddress: "127.0.0.1" | |
protocol: tcp | |
# e2e image registry service's NodePort | |
- containerPort: 30000 | |
hostPort: 30000 | |
listenAddress: "127.0.0.1" | |
protocol: tcp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks for catching that.
Signed-off-by: yashoza19 <yoza@redhat.com>
Signed-off-by: yashoza19 <yoza@redhat.com>
Description
Reviewer Checklist