Added e2e test for operator resolution #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awgreene
reviewed
Jan 26, 2023
test/e2e/install_test.go
Outdated
| Name: fmt.Sprintf("operator-%s", rand.String(8)), | ||
| }, | ||
| Spec: operatorv1alpha1.OperatorSpec{ | ||
| PackageName: "prometheus", |
tmshort
reviewed
Jan 26, 2023
| @@ -0,0 +1,61 @@ | |||
| package e2e | |||
There was a problem hiding this comment.
I think package e2e is fine - there's only tests and test tooling here...no?
There was a problem hiding this comment.
Yeah that's right, I feel like I usually just see that convention when we have actualpkg and then when we test it actualpkg_test
|
/lgtm |
openshift-ci
bot
added
lgtm
grokspawn
approved these changes
Jan 27, 2023
dtfranz
force-pushed
the
resolver-e2e-test
branch
from
a3acd70
to
385a889
Compare
|
/lgtm |
…ning e2e tests Signed-off-by: dtfranz <dfranz@redhat.com>
dtfranz
force-pushed
the
resolver-e2e-test
branch
from
385a889
to
4b51ca6
Compare
|
New changes are detected. LGTM label has been removed. |
This was referenced Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolver e2e test for Operator Controller. Creates an Operator Resource specifying prometheus as the packageName then expects resolution to succeed and provide a bundle path.