Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix the kind-redeploy target #1031

Closed
wants to merge 1 commit into from

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jul 10, 2024

Alternative to #1004

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Todd Short <tshort@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2024
@tmshort tmshort marked this pull request as ready for review July 10, 2024 17:57
@tmshort tmshort requested a review from a team as a code owner July 10, 2024 17:57
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2024
Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit a719fd0
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/668ecb99e509df0008d96e96
😎 Deploy Preview https://deploy-preview-1031--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.60%. Comparing base (db5a75c) to head (a719fd0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1031   +/-   ##
=======================================
  Coverage   77.60%   77.60%           
=======================================
  Files          18       18           
  Lines        1268     1268           
=======================================
  Hits          984      984           
  Misses        202      202           
  Partials       82       82           
Flag Coverage Δ
e2e 56.44% <ø> (ø)
unit 52.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort
Copy link
Contributor Author

tmshort commented Jul 11, 2024

Closing in favor of #1004

@tmshort tmshort closed this Jul 11, 2024
@tmshort tmshort deleted the kind-redeploy branch July 11, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant