-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 lint update #1036
🌱 lint update #1036
Conversation
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1036 +/- ##
==========================================
- Coverage 77.60% 77.00% -0.60%
==========================================
Files 18 19 +1
Lines 1268 1357 +89
==========================================
+ Hits 984 1045 +61
- Misses 202 222 +20
- Partials 82 90 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1718fbd
to
d785815
Compare
13e7bee
to
73f5c7d
Compare
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
73f5c7d
to
6e1b28f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
60d26ed
* update golangci-lint version Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> * update golangci-lint configuration Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> * update make fmt target Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> * fix lint issues Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> --------- Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>
* update golangci-lint version Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> * update golangci-lint configuration Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> * update make fmt target Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> * fix lint issues Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> --------- Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>
Description
Updates golangci-lint to its latest version and updates the config to remove a todo.
Adds a Makefile target
make fix-fmt
that runs golangci-lint --fix to (hopefully) fix (most) of the issues automagically.Addresses a gosec lint issue where the perms for a file (in a directory that the operator-controller creates) were too broad (0777) -> 0600. I think this should be ok.
Reviewer Checklist