🌱 lint update #1036
Merged
🌱 lint update #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 11, 2024 17:03
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1036 +/- ##
==========================================
- Coverage 77.60% 77.00% -0.60%
==========================================
Files 18 19 +1
Lines 1268 1357 +89
==========================================
+ Hits 984 1045 +61
- Misses 202 222 +20
- Partials 82 90 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tmshort
reviewed
Jul 11, 2024
perdasilva
force-pushed
the
perdasilva/fixfmt
branch
from
1718fbd
to
d785815
Compare
perdasilva
force-pushed
the
perdasilva/fixfmt
branch
2 times, most recently
from
13e7bee
to
73f5c7d
Compare
added 2 commits
July 12, 2024 10:15
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
perdasilva
force-pushed
the
perdasilva/fixfmt
branch
from
73f5c7d
to
6e1b28f
Compare
Merged
via the queue into
operator-framework:main
with commit Jul 12, 2024
60d26ed
15 of 17 checks passed
perdasilva
added a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Aug 13, 2024
* update golangci-lint version Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> * update golangci-lint configuration Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> * update make fmt target Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> * fix lint issues Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> --------- Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>
perdasilva
added a commit
to kevinrizza/operator-controller
that referenced
this pull request
Aug 13, 2024
* update golangci-lint version Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> * update golangci-lint configuration Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> * update make fmt target Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> * fix lint issues Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> --------- Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates golangci-lint to its latest version and updates the config to remove a todo.
Adds a Makefile target
make fix-fmtthat runs golangci-lint --fix to (hopefully) fix (most) of the issues automagically.Addresses a gosec lint issue where the perms for a file (in a directory that the operator-controller creates) were too broad (0777) -> 0600. I think this should be ok.
Reviewer Checklist