-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠ Move all packages from /pkg to /internal #1043
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1043 +/- ##
=======================================
Coverage 75.44% 75.44%
=======================================
Files 35 35
Lines 1918 1918
=======================================
Hits 1447 1447
Misses 329 329
Partials 142 142
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We have a bunch of other commits (i.e. @dtfranz's import of rukpak) that we may want to wait on before we do this. |
@kevinrizza, this needs to be rebased as #1032 was merged |
@kevinrizza are you going update this? |
2747715
to
e88e338
Compare
Yeah, the location of a number of import lines changed, and this is causing lint problems. |
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
e88e338
to
58c17e1
Compare
Fixed ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
API diff is expected as components are being moved from pkg
to internal
368fd7c
Ahead of an initial 1.0.0 release, we shouldn't preemptively expose any packages publicly. Instead, let's start my making any packages internal, and we can expose them publicly later on. This commit moves everything currently in /pkg to /internal for now.