-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 consolidate and save all coverage data under ./coverage #1044
🌱 consolidate and save all coverage data under ./coverage #1044
Conversation
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
=======================================
Coverage 73.46% 73.46%
=======================================
Files 32 32
Lines 1986 1986
=======================================
Hits 1459 1459
Misses 368 368
Partials 159 159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
test-unit: $(SETUP_ENVTEST) #HELP Run the unit tests | ||
eval $$($(SETUP_ENVTEST) use -p env $(ENVTEST_VERSION) $(SETUP_ENVTEST_BIN_DIR_OVERRIDE)) && CGO_ENABLED=1 go test -count=1 -race -short $(UNIT_TEST_DIRS) -coverprofile cover.out | ||
rm -rf $(COVERAGE_UNIT_DIR) && mkdir -p $(COVERAGE_UNIT_DIR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the &&
is not necessary in a Makefile
…mework#1044) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
…mework#1044) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Description
Move:
./e2e-cover.out
->./coverage/e2e.out
./cover.out
->./coverage/unit.out
Add Go 1.20+ gocoverdirs
./coverage/e2e
./coverage/unit
Reviewer Checklist