🌱 upgrade test: wait until first reconcile completes after upgrade #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1045 +/- ##
=======================================
Coverage 73.46% 73.46%
=======================================
Files 32 32
Lines 1986 1986
=======================================
Hits 1459 1459
Misses 368 368
Partials 159 159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
acornett21
approved these changes
Jul 12, 2024
tmshort
approved these changes
Jul 15, 2024
Comment on lines
+132
to
+138
| foundCount := 0 | ||
| for _, substring := range substrings { | ||
| if strings.Contains(line, substring) { | ||
| foundCount++ | ||
| } | ||
| } | ||
| if foundCount == len(substrings) { |
There was a problem hiding this comment.
I feel like this could be done with a regexp
perdasilva
pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Aug 13, 2024
…rator-framework#1045) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
perdasilva
pushed a commit
to kevinrizza/operator-controller
that referenced
this pull request
Aug 13, 2024
…rator-framework#1045) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the upgrade, make sure reconcile actually completes for the ClusterExtension before we being the post-upgrade checks and tests.
Reviewer Checklist