Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Move all e2e scripts into one location #1046

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Jul 15, 2024

Description

Follow up for #1003 (review).

Some of the e2e scripts were in ./hack and some were in ./test/tools. Moved everything into single location. Everything is in ./hack/test now.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@m1kola m1kola requested a review from a team as a code owner July 15, 2024 11:59
@m1kola m1kola requested a review from tmshort July 15, 2024 11:59
Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit b7462b3
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6698d0fc9801ec000821c0f3
😎 Deploy Preview https://deploy-preview-1046--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.50%. Comparing base (6cd022e) to head (b7462b3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1046   +/-   ##
=======================================
  Coverage   72.50%   72.50%           
=======================================
  Files          32       32           
  Lines        1884     1884           
=======================================
  Hits         1366     1366           
  Misses        383      383           
  Partials      135      135           
Flag Coverage Δ
e2e 55.33% <ø> (ø)
unit 44.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort
Copy link
Contributor

tmshort commented Jul 15, 2024

I would actually suggest moving from hack into test/tools. hack to me means something completely different...

@m1kola
Copy link
Member Author

m1kola commented Jul 15, 2024

I moved it into hack because we use ./hack dir in a few other repos (OLMv0, catalogd, probably more) and it was historically preceding ./test/tools.

But I'm not opposed into getting rid of ./hack and moving everything into ./test/tools. I'll get back to it tomorrow.

@perdasilva
Copy link
Contributor

Just my 2c (nothing blocking), seems the hack directory pattern is a k8s'ism (e.g. kubernetes/kops#444) - seems many go projects copied it. While not against moving to ./test/tools, the hack dir may already be an expectation for many k8s devs in the wild.

As an alternative, we could also move test/tools to /hack/test - and have a hack/misc for more specific purposed, non-critical-path, type scripts.

@tmshort
Copy link
Contributor

tmshort commented Jul 16, 2024

I'd be ok with hack/test, it's at least a bit more descriptive... that being said, I really hate the misuse of the term "hack" (e.g. "life hack").

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2024
@tmshort
Copy link
Contributor

tmshort commented Jul 17, 2024

@m1kola ?

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2024
@m1kola
Copy link
Member Author

m1kola commented Jul 18, 2024

Sorry, something more urgent/importnat came up and I was focusing on it.

Moved everything into ./hack/test.

Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tmshort tmshort added this pull request to the merge queue Jul 18, 2024
Merged via the queue into operator-framework:main with commit 5106e15 Jul 18, 2024
18 checks passed
@m1kola m1kola deleted the move_tools branch July 18, 2024 13:22
perdasilva pushed a commit to LalatenduMohanty/operator-controller that referenced this pull request Aug 13, 2024
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
perdasilva pushed a commit to kevinrizza/operator-controller that referenced this pull request Aug 13, 2024
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants