⚠: Ambiguous Resolution #1165
Merged
⚠: Ambiguous Resolution #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dtfranz
force-pushed
the
ambiguous-resolution
branch
from
9086fbc
to
4a89500
Compare
dtfranz
commented
Aug 22, 2024
tmshort
reviewed
Aug 22, 2024
|
You need to update the test-e2e, which will be a pain in the ass until the selector is available (see #1164) so we might want to merge that one in first... |
|
You might want to rebase now that #1164 is merged. |
Changes the behavior of catalog resolution by returning an error when multiple packages are available from multiple catalogs. Signed-off-by: dtfranz <dfranz@redhat.com>
dtfranz
force-pushed
the
ambiguous-resolution
branch
from
4a89500
to
132c34d
Compare
|
PR has been rebased and updated with @tmshort 's e2e test. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1165 +/- ##
==========================================
- Coverage 75.42% 75.28% -0.15%
==========================================
Files 35 35
Lines 1925 1934 +9
==========================================
+ Hits 1452 1456 +4
- Misses 330 332 +2
- Partials 143 146 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
via the queue into
operator-framework:main
with commit Aug 22, 2024
2391092
18 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the behavior of catalog resolution by returning an error when multiple packages are available from multiple catalogs.
Users will need to use forthcoming label selectors to narrow down catalogs when this occurs.
Closes #1110
Description
Reviewer Checklist