Reduce reconcile complexity #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/hold
joelanford
force-pushed
the
reduce-reconcile-complexity
branch
from
98a258c
to
6ad5c2b
Compare
- reduce cyclomatic complexity from 8 to 5 - make it more obvious when and how conditions are set when various errors occur - when errors occur: always set ready condition, always return the error
joelanford
force-pushed
the
reduce-reconcile-complexity
branch
from
6ad5c2b
to
9453ff6
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
5 tasks
tmshort
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the cyclomatic complexity of the
reconcilemethod of the operator controller from 8 to 5 (as measured by gocyclo), mainly by factoring out the bundle entity lookup from the solution into a separate function.It also ensures all code paths set the
Readycondition, which required two new reasons (BundleLookupFailedandBundleDeploymentFailed)This is built on top of #115, so
/hold
until that has merged and we've rebased this one.