Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove unnecessary type casting in the finaliser #1205

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Sep 3, 2024

Description

We can get object's name without type casting.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola requested a review from a team as a code owner September 3, 2024 11:25
Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 749f2e7
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66d6f235f2b60500089277f7
😎 Deploy Preview https://deploy-preview-1205--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.50%. Comparing base (d2b859b) to head (749f2e7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
- Coverage   77.56%   77.50%   -0.07%     
==========================================
  Files          36       36              
  Lines        1979     1978       -1     
==========================================
- Hits         1535     1533       -2     
- Misses        309      310       +1     
  Partials      135      135              
Flag Coverage Δ
e2e 57.63% <100.00%> (+0.07%) ⬆️
unit 55.51% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford joelanford added this pull request to the merge queue Sep 3, 2024
Merged via the queue into operator-framework:main with commit 0f956dc Sep 3, 2024
17 of 18 checks passed
@m1kola m1kola deleted the simplify_cluster_extension_finaliser branch September 3, 2024 14:09
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants