api: add tests that ensure types and reasons are registered correctly #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelanford
force-pushed
the
test-register-types-reasons
branch
from
cb96d05
to
6e9c763
Compare
perdasilva
reviewed
Feb 27, 2023
| }) | ||
| }) | ||
|
|
||
| func parseConstants(prefix string) ([]string, error) { |
There was a problem hiding this comment.
nice! could be cool to add a couple of comments for those unfamiliar with the the ast package
perdasilva
approved these changes
Feb 27, 2023
|
@joelanford could you please rebase? |
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
test-register-types-reasons
branch
from
6e9c763
to
79ad2c8
Compare
|
Done! Thanks for the review @perdasilva! |
perdasilva
pushed a commit
to perdasilva/operator-controller
that referenced
this pull request
Mar 3, 2023
…operator-framework#122) Signed-off-by: Joe Lanford <joe.lanford@gmail.com> Signed-off-by: perdasilva <perdasilva@redhat.com>
perdasilva
pushed a commit
to perdasilva/operator-controller
that referenced
this pull request
Mar 3, 2023
…operator-framework#122) Signed-off-by: Joe Lanford <joe.lanford@gmail.com> Signed-off-by: perdasilva <perdasilva@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently export constants for the universe of types and reasons that the operator controller uses to set conditions. And we append them to a list that is used in reconciler tests to ensure that
Reconcilesets each condition type during any given call. See here.However there's still a small gap. It's possible to add a new type/reason without appending it into the respective operatorutil list, which means the assumptions we make (i.e. that the operatorutil lists are exhaustive) are not enforced. And that means our invariant test for "all types must be set at the end of a reconcile call" might produce false negatives.
This PR closes that gap by adding a test that ensures that:
TypeorReason, its value exists in the respective operatorutil slice.TypeorReasonprefixed constant.