Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖[Docs] How-to: Channel-Based Automatic Updates #1220

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Sep 5, 2024

Description

Closes #1129

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva perdasilva requested a review from a team as a code owner September 5, 2024 15:33
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 2efe604
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66db1286446bda0008263a32
😎 Deploy Preview https://deploy-preview-1220--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.49%. Comparing base (3a9868e) to head (2efe604).
Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1220      +/-   ##
==========================================
- Coverage   77.55%   76.49%   -1.07%     
==========================================
  Files          35       40       +5     
  Lines        1916     2340     +424     
==========================================
+ Hits         1486     1790     +304     
- Misses        296      393      +97     
- Partials      134      157      +23     
Flag Coverage Δ
e2e 57.64% <ø> (-1.12%) ⬇️
unit 52.43% <ø> (-2.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@OchiengEd OchiengEd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I recommend slight rewording

name: argocd-installer
```

Note that the `version` version range can also be set to further restrict the set of possible versions to upgrade to.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be made clearer. Perhaps something like,

Note that the `version` field also accepts a version range to further restrict the set of possible operator versions to upgrade to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!!

I've updated it and tried to remove the preposition at the end? wdyt?

@perdasilva perdasilva force-pushed the perdasilva/docs/howto-channel-based-upgd branch 2 times, most recently from 17e52f2 to e928d0a Compare September 6, 2024 08:01
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva force-pushed the perdasilva/docs/howto-channel-based-upgd branch from e928d0a to 2efe604 Compare September 6, 2024 14:32
@everettraven everettraven added this pull request to the merge queue Sep 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2024
@joelanford joelanford added this pull request to the merge queue Sep 7, 2024
Merged via the queue into operator-framework:main with commit ac5c28b Sep 7, 2024
17 of 18 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Accept automatic upgrades within a specific channel
4 participants