Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 [Docs] Improve developer.md #1289

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

bentito
Copy link
Contributor

@bentito bentito commented Sep 20, 2024

Replace kube context mention;
Improve Mac brew usage

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Replace kube context mention;
Improve Mac brew usage

Signed-off-by: Brett Tofel <btofel@redhat.com>
@bentito bentito requested a review from a team as a code owner September 20, 2024 13:08
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 2bbc9cb
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66ed73bed3476f0008b599ac
😎 Deploy Preview https://deploy-preview-1289--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thank you!!

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.51%. Comparing base (f3e2ce0) to head (2bbc9cb).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1289   +/-   ##
=======================================
  Coverage   76.51%   76.51%           
=======================================
  Files          39       39           
  Lines        2363     2363           
=======================================
  Hits         1808     1808           
  Misses        389      389           
  Partials      166      166           
Flag Coverage Δ
e2e 57.93% <ø> (ø)
unit 52.94% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford joelanford added this pull request to the merge queue Sep 20, 2024
Merged via the queue into operator-framework:main with commit dc4141a Sep 20, 2024
18 checks passed
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants