Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Improving the error when fail to find the authFilePath #1313

Conversation

LalatenduMohanty
Copy link
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@LalatenduMohanty LalatenduMohanty requested a review from a team as a code owner September 26, 2024 17:53
Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 41e5872
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66f5a3da13ba38000828c02e
😎 Deploy Preview https://deploy-preview-1313--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cmd/manager/main.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.27%. Comparing base (d9cf2ed) to head (05ca960).

Files with missing lines Patch % Lines
cmd/manager/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1313   +/-   ##
=======================================
  Coverage   76.27%   76.27%           
=======================================
  Files          40       40           
  Lines        2398     2398           
=======================================
  Hits         1829     1829           
  Misses        401      401           
  Partials      168      168           
Flag Coverage Δ
e2e 58.79% <0.00%> (ø)
unit 52.50% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford
Copy link
Member

@LalatenduMohanty I found some other logging improvements to make. See #1316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants