Conditions: Map out-of-date bundleDeployment with an operator condition

[varshaprasad96]

This PR brings in the change that sets the operator condition to Unknown when the BundleDeployment's conditions are out od date.

[varshaprasad96]

This is hacky, but needed since we are trying to mimic >1 reconcile.

[joelanford]

A better approach might be to have separate When blocks. Something along these lines, maybe?

When("The bundle deployment status is stale", func() {})
When("The bundle deployment status is up-to-date", func() {
	BeforeEach(func() {
		bd.Status.ObservedGeneration = bd.GetGeneration()
		By("updating the status of bundleDeployment")
		err := cl.Status().Update(ctx, bd)
		Expect(err).NotTo(HaveOccurred())
	}
})

Also, I find it easier to think about these tests not as mimicking multiple reconciles, but more like "what happens during a given Reconcile when the state of the world is X?". And then we would ideally have tests for all the various X's such that we get really good code coverage in Reconcile.

[varshaprasad96]

Made the change, just left the status update call in It blocks, so that we update the status only once after setting the right conditions.

[joelanford]

A better approach might be to have separate When blocks. Something along these lines, maybe?

When("The bundle deployment status is stale", func() {})
When("The bundle deployment status is up-to-date", func() {
	BeforeEach(func() {
		bd.Status.ObservedGeneration = bd.GetGeneration()
		By("updating the status of bundleDeployment")
		err := cl.Status().Update(ctx, bd)
		Expect(err).NotTo(HaveOccurred())
	}
})

Also, I find it easier to think about these tests not as mimicking multiple reconciles, but more like "what happens during a given Reconcile when the state of the world is X?". And then we would ideally have tests for all the various X's such that we get really good code coverage in Reconcile.

[joelanford]

/lgtm

[openshift-ci]

New changes are detected. LGTM label has been removed.

[varshaprasad96]

@joelanford Re-organized the test cases, please feel free to let me know if you would like to see any other changes. I can do those in follow-ups, merging this for now.