Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Makefile with Taskfile #137

Closed
wants to merge 3 commits into from

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Mar 4, 2023

Experimenting with replacing Makefile with Taskfile: https://taskfile.dev/

A few observations:

  • notion of internal vs external tasks, tasks can use other tasks but those subtasks can be hidden from the task CLI
  • built-in ways to group tasks
  • built-in documentation (both short one-liner and long-form paragraphs).. this seems like it would be an amazing thing to have as a new contributor
  • defer keyword that let's you do stuff when a task completes
  • developers can put their own custom tasks in Taskfile.yaml (and we could .gitignore it). The task cli picks those up automatically.

In this PR, there are also a few extras that are orthogonal to the Makefile/Taskfile choice:

  • code coverage instrumentation of both unit and e2e tests and upload to codecov
  • bump to Go 1.20 (needed for instrumenting binaries with coverage, used in e2e)
  • combine github test workflows into a matrix
  • a few improvements in the goreleaser for go build flags used.
  • getting rid of make quickstart but replacing it with build:manifest and build:install-script and then actually using that manifest and install script to a) run build locally via kind b) run e2e tests c) publish a release

@joelanford joelanford changed the title Taskfile WIP: Taskfile Mar 4, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2023
@joelanford joelanford force-pushed the taskfile branch 3 times, most recently from b29012e to 2d2597e Compare March 4, 2023 18:02
@joelanford joelanford changed the title WIP: Taskfile WIP: s/Makefile/Taskfile/ Mar 4, 2023
@joelanford joelanford force-pushed the taskfile branch 7 times, most recently from f36c65e to c492781 Compare March 10, 2023 18:31
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@eb0312c). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage        ?   81.54%           
=======================================
  Files           ?       12           
  Lines           ?      829           
  Branches        ?        0           
=======================================
  Hits            ?      676           
  Misses          ?      120           
  Partials        ?       33           
Flag Coverage Δ
e2e 61.51% <0.00%> (?)
unit 76.90% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2023
@joelanford joelanford changed the title WIP: s/Makefile/Taskfile/ Replace Makefile with Taskfile Mar 30, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2023
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joelanford joelanford closed this Sep 14, 2023
@joelanford joelanford deleted the taskfile branch July 20, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants